ci: Refactor Docker workflow#285
Merged
Merged
Conversation
Vamshi-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Roopan-Microsoft,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
Vamshi-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Vamshi-Microsoft
had a problem deploying
to
production
GitHub Actions
Error
Vamshi-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the GitHub Actions Docker build/push reusable workflow and related deployment workflows to use repository/environment variables (instead of secrets) for the ACR login server, while simplifying how the Docker build job is triggered.
Changes:
- Updated workflow references from
secrets.ACR_TEST_LOGIN_SERVERtovars.ACR_TEST_LOGIN_SERVER. - Removed
workflow_callinputs fromjob-docker-build.yml, addedworkflow_dispatch, and added explicit OIDC permissions. - Adjusted ACR login in
job-docker-build.ymlto derive the registry name from the login server before callingaz acr login.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/job-docker-build.yml | Removes workflow-call inputs, adds manual dispatch + permissions, switches ACR login server to vars and refines az acr login. |
| .github/workflows/job-deploy-windows.yml | Switches ACR login server reference to vars for AZD env configuration. |
| .github/workflows/job-deploy-linux.yml | Switches ACR login server reference to vars for AZD env configuration. |
| .github/workflows/deploy-orchestrator.yml | Removes passing inputs into job-docker-build.yml but still gates the job via inputs.* condition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Vamshi-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Vamshi-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
Roopan-Microsoft
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the GitHub Actions workflows to improve how Azure Container Registry (ACR) credentials are managed and simplifies the Docker build workflow. The main changes involve switching from using secrets to using variables for the ACR login server, updating the Docker image build and push steps to use these variables, and cleaning up workflow inputs and conditions.
Azure Container Registry (ACR) credential management:
secrets.ACR_TEST_LOGIN_SERVERtovars.ACR_TEST_LOGIN_SERVERin the Linux and Windows deployment workflows (job-deploy-linux.yml,job-deploy-windows.yml) and in all Docker build and push steps injob-docker-build.yml[1] [2] [3] [4] [5] [6] [7].Workflow input and trigger simplification:
trigger_type,build_docker_image) fromjob-docker-build.ymland updated the workflow to be triggered directly byworkflow_dispatch.inputs.trigger_typeandinputs.build_docker_imagein thedeploy-orchestrator.ymlworkflow, simplifying the job trigger logic.Docker build job improvements:
These changes make the workflows more maintainable, secure, and easier to trigger and manage.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information